[VL] Restrict -Wno-class-memaccess flag to GNU compiler#11429
Merged
PHILO-HE merged 2 commits intoapache:mainfrom Jan 19, 2026
Merged
[VL] Restrict -Wno-class-memaccess flag to GNU compiler#11429PHILO-HE merged 2 commits intoapache:mainfrom
-Wno-class-memaccess flag to GNU compiler#11429PHILO-HE merged 2 commits intoapache:mainfrom
Conversation
liujiayi771
force-pushed
the
clang-error
branch
from
b66f1eb to
74db4e1
Compare
liujiayi771
force-pushed
the
clang-error
branch
from
74db4e1 to
f995f48
Compare
PHILO-HE
reviewed
Jan 19, 2026
cpp/CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| if(NOT ${CMAKE_SYSTEM_NAME} STREQUAL "Darwin") | ||
| if(NOT "${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin" AND "${CMAKE_CXX_COMPILER_ID}" |
Member
There was a problem hiding this comment.
Thanks for the fix. Since -Wno-class-memaccess is a GNU-specific flag (and likely independent of the OS), can we remove the first condition and only check the compiler ID?
Contributor
Author
There was a problem hiding this comment.
@PHILO-HE Yes, I’ve also considered removing this part before. The "Darwin" check here was likely added because macOS defaults to Clang, which caused some compilation failures.
PHILO-HE
changed the title
-Wno-class-memaccess flag to GNU compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Only GNU GCC supports this flag; using Clang to compile will result in an error.
How was this patch tested?
N/A